MOOSE is a collaborative effort and we always welcome contributions! When contributing to MOOSE you need to keep in mind that hundreds of people are depending on this code to do their jobs every day. Because of that we have specific policies, procedures and automated processes in place to maintain high code quality while allowing many changes to flow into the code daily.
If you are somewhat new to Git or GitHub we have worked up a set of slides to walk you through the processes of modifying MOOSE and submitting patches.
Otherwise a brief overview can be found below:
When modifying or adding to MOOSE you need to follow the strict MOOSE Code Standard. These guidelines ensure a common look and feel to all of the code in MOOSE allowing developers to seamlessly move between sections of code and giving users a consistent interface.
Every modification to MOOSE must reference an issue number. This means that every commit that flows into MOOSE must have a #NNNN (where NNNN are the numbers for an issue such as #1234) present in the commit message. Further, every Pull Request also needs to reference an issue number in both its description. Issue numbers are automatically checked for by our testing system.
The first step in modifying MOOSE is to create your own fork where you can commit your set of changes:
git clone https://github.com/username/moose.git
If this returns "fatal: Unable to find remote helper for 'https'" you might be behind a firewall. Try:
git clone firstname.lastname@example.org:username/moose.git
Add the real MOOSE repository as a remote named "upstream":
cd moose git remote add upstream https://github.com/idaholab/moose.git
or, if you had a problem with https,
cd moose git remote add upstream email@example.com:idaholab/moose.git
git add your_file.h your_file.C git commit -m "A message about the commit closes #12345"
Note: The MOOSE team prefers that you format your commit messages as follows:
Short Description or Title of PR (less than 50 characters) [blank line] More detail of your PR if needed. - Bulleted lists are encouraged - Fixes - Enhancements Reference your ticket using the keyword "closes" if appropriate to automatically close the issue when your PR is merged. closes #12345
git fetch upstream git rebase upstream/devel
Push your branch back into your fork on GitHub:
git push origin branch_name
GitHub utilizes Pull Requests (PRs) to allow you to submit changes stored in your Fork back to the main MOOSE repository. If you are generally interested in how PRs work you can look at the official GitHub documentation. MOOSE utilizes the "Fork & Pull" collaborative development model.
In addition: our own slides are a great way to learn about the process of submitting a PR for the MOOSE project.
The main thing to remember when issuing a PR for MOOSE is that all PRs should be specified to go to the
The next phase is covered in How a Patch Becomes Code... that will take you through the process of a PR ultimately making it's way into the
master branch in MOOSE...